Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update storybook to 8.4.7 #25451

Merged
merged 23 commits into from
Jan 20, 2025
Merged

update storybook to 8.4.7 #25451

merged 23 commits into from
Jan 20, 2025

Conversation

ghernandez345
Copy link
Contributor

@ghernandez345 ghernandez345 commented Jan 15, 2025

For #25349

This updates storybook and its addons to 8.4.7. This is done to remove the transitive dependency on path-to-regexp,
which is no longer used in this version of storybook.

This will fix the original vulnerability issue for path-to-regexp

lukeheath
lukeheath previously approved these changes Jan 15, 2025
Copy link
Member

@lukeheath lukeheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@lukeheath
Copy link
Member

@ghernandez345 Tests failed, I'm re-running.

@ghernandez345
Copy link
Contributor Author

@lukeheath im having an issue with the test failing to run but only in the github actions. everything works for me locally. Can you pull this locally and run make deps and then try to run yarn test? I'm wondering if it will work for you locally as well.

@ghernandez345
Copy link
Contributor Author

im gonna close this PR and try to open a new one to see if this helps the github test action pass.

@ghernandez345
Copy link
Contributor Author

ghernandez345 commented Jan 16, 2025

reopening as a new PR didnt seems to help

@ghernandez345 ghernandez345 force-pushed the fix-ui-path-to-regex-dep-version branch from 1c7eb89 to dc0e74d Compare January 20, 2025 10:54
@ghernandez345 ghernandez345 merged commit 8168ff3 into main Jan 20, 2025
14 checks passed
@ghernandez345 ghernandez345 deleted the fix-ui-path-to-regex-dep-version branch January 20, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants